Skip to content

Fix generateContentStream returning wrong inferenceSource. #9381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix generateContentStream returning wrong inferenceSource. #9381

wants to merge 2 commits into from
+39 −3

Conversation

@hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Nov 13, 2025 •
edited
Loading

generateContentStream was returning in_cloud no matter what.

Need to pass inferenceSource to processStream.

Added tests to catch.

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: aa73fa5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/ai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review November 13, 2025 19:57
@hsubox76 hsubox76 requested review from a team as code owners November 13, 2025 19:57
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 13, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/ai

    TypeBase (b228a2a)Merge (2ba3090)Diff
    browser67.4 kB67.4 kB+27 B (+0.0%)
    main71.7 kB71.7 kB+27 B (+0.0%)
    module67.4 kB67.4 kB+27 B (+0.0%)

  • firebase

    TypeBase (b228a2a)Merge (2ba3090)Diff
    firebase-ai.js52.8 kB52.8 kB+18 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ONJ4EuExwK.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 13, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/ai

    • ChatSession

      Size

      TypeBase (b228a2a)Merge (2ba3090)Diff
      size22.3 kB22.3 kB+18 B (+0.1%)
      size-with-ext-deps40.0 kB40.1 kB+18 B (+0.0%)

    • GenerativeModel

      Size

      TypeBase (b228a2a)Merge (2ba3090)Diff
      size26.0 kB26.1 kB+18 B (+0.1%)
      size-with-ext-deps43.8 kB43.9 kB+18 B (+0.0%)

    • getGenerativeModel

      Size

      TypeBase (b228a2a)Merge (2ba3090)Diff
      size26.4 kB26.4 kB+18 B (+0.1%)
      size-with-ext-deps44.2 kB44.2 kB+18 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1rh6WbM6wT.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hsubox76 @google-oss-bot